Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded icon path in launcher for GNU/Linux systems #17

Closed
Tracked by #221
palob opened this issue Mar 28, 2015 · 2 comments
Closed
Tracked by #221

Hardcoded icon path in launcher for GNU/Linux systems #17

palob opened this issue Mar 28, 2015 · 2 comments

Comments

@palob
Copy link
Contributor

palob commented Mar 28, 2015

Hi,

currently the icon path specified in the created launcher file is set to:
Icon=multibootusb.png

(see https://github.com/mbusb/multibootusb/blob/64f42fecd1c0f7361d5052830daec58bec72690f/data/multibootusb.desktop)

This prevents icon theming without editing the launcher file.

I'd like to ask you to change the icon location as well as the icon path line in the launcher according to the freedesktop.org standards.

Please find more info here:
http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
https://github.com/Foggalong/hardcode-fixer/wiki/What,-Why-&-How


According to the above resources standard icon locations are:

/usr/share/icons/hicolor/[size]/apps/[icon name]
~/.local/share/icons/hicolor/[size]/apps/[icon name]
/usr/share/pixmaps/[icon name]

Your icon multibootusb.png is already stored in a standard location (/usr/share/pixmaps).

But the standard icon line in the .desktop launcher is:
Icon=[icon name] (neither full path, nor the file extension are needed)

for instance
Icon=multibootusb
(for an icon multibootusb.svg or multibootusb.png stored in standard location)

Could you please adjust the icon path in the .desktop file accordingly?

@mbusb
Copy link
Owner

mbusb commented Mar 30, 2015 via email

@mbusb
Copy link
Owner

mbusb commented Apr 9, 2015

Fixed in the latest source file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants