Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think your code has been stolen #2

Open
rhubarbdog opened this issue Dec 19, 2022 · 1 comment
Open

I think your code has been stolen #2

rhubarbdog opened this issue Dec 19, 2022 · 1 comment

Comments

@rhubarbdog
Copy link

hi
user https://github.com/vittascience in their https://github.com/vittascience/microbit-libraries would appear to have stolen some of my code for dht11.
I think they have either taken the forked copy of your code i have in repository https://github.com/rhubarbdog/microbit-tm1637 or directly taken it from your repository.

similarities
object class definition uses variable names clk and dio
they have shortened the _SEG byte array constant
but still use 0x39 and 0x63 in a method called temperature
there is also a method called numbers with parameters num1 and num2

@mcauser
Copy link
Owner

mcauser commented Dec 19, 2022

Hi @rhubarbdog Thanks for the tip.
It's open source, so allowed to be forked, modified and improved, so long as they keep the MIT copyright notice, which they seem to have discarded when minifying. I added a comment to your raised issue linking to the MIT license requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants