Fix #268: added platform support to Catena 4802 #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrillmoore
requested changes
Dec 18, 2020
There was a problem hiding this comment.
Sorry ... the #ifs require that this be reworked. It's architecturally not permitted to add board-specific dependencies in higher-level include files. So this can't be merged as is.
The best policy is not ever to use #if unless there is no alternative due to the IDE limitations. That's not the case here; a combination of virtual methods and careful hierarchy will suffice.
|
made the suggested changes and tested build with example sketches. They compile successfully. Catena-Arduino-Platform/src/Catena4802.h Line 44 in 9482a42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to new board Catena 4802, changes done: