Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 4450/4551 to use common code #65

Closed
terrillmoore opened this issue Jun 3, 2018 · 1 comment
Closed

Refactor 4450/4551 to use common code #65

terrillmoore opened this issue Jun 3, 2018 · 1 comment
Assignees

Comments

@terrillmoore
Copy link
Member

terrillmoore commented Jun 3, 2018

Many routines like GetSysEUI() are duplicated in the samd and stm32 dirs because of different FRAM types. But the FRAMs (2k and 8k) export a common API so instead of this->m_Fram we could use this->GetFram() as long as GetFram() returns an Fram reference (Fram&).

For others (like registerCommands) there seems to be no good reason for them to be separate (though again it may be the FRAM stuff.

@terrillmoore
Copy link
Member Author

@chwon64, did you see this? This idea would be a global substitution to change every this->m_Fram reference to this->GetFram() (and implement that method). Since this could return an Fram&, we could get refactor the rest of the code that is dependent on the FRAM type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants