Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review FSK code looking for 1272/1276 glitches #346

Closed
terrillmoore opened this issue Jul 13, 2019 · 1 comment
Closed

Review FSK code looking for 1272/1276 glitches #346

terrillmoore opened this issue Jul 13, 2019 · 1 comment
Assignees
@terrillmoore
Labels
bug

Comments

@terrillmoore
Copy link
Member

As shown by #344, the code has some sx1272 dependencies in the FSK path, and is using hard constants rather than #defines.. we should do a quick pass to clean this up. (But how to test?)
@terrillmoore terrillmoore self-assigned this Jul 13, 2019
@terrillmoore terrillmoore mentioned this issue Aug 17, 2019
Closed
@terrillmoore
Copy link
Member Author

Test at least with compliance test.

@terrillmoore terrillmoore mentioned this issue Aug 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrillmoore