Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MAC commands to match names in LoRaWAN 1.0.3 #371

Closed
terrillmoore opened this issue Aug 18, 2019 · 1 comment
Closed

Rename MAC commands to match names in LoRaWAN 1.0.3 #371

terrillmoore opened this issue Aug 18, 2019 · 1 comment
Assignees
@terrillmoore
Labels
enhancement

Comments

@terrillmoore
Copy link
Member

When rewriting the MAC parser, it became clear that the names in the code need to match the spec. My guess is that the names pre-dated the LoRaWAN 1.0 spec. In any case, I changed the bulk of the MCMD_... symbols to be MCMD_{specname}. So for example, MCMD_DCAP_REQ became MCMD_DutyCycleReq. This led to discovery of several errors, and made it much easier to go back and forth between code and spec.
@terrillmoore terrillmoore self-assigned this Aug 18, 2019
@terrillmoore
Copy link
Member Author

Fixed by #378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrillmoore