New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference to ISO 3166-1 alpha-2 #63

Closed

terrillmoore opened this issue Jun 1, 2018 · 0 comments

Member

terrillmoore commented Jun 1, 2018

arduino-lmic/src/lmic/lmic_config_preconditions.h

Lines 74 to 78 in 16177b3

    
           // country codes for comparison. These values are chosen from the 2-letter domain suffixes (which 
        
           // I think are ISO standardized) 
        
           #define LMIC_COUNTRY_CODE_C(c1, c2)     ((c1) * 256 + (c2))

These are standardized under ISO 3166-1 alpha-2 (see Wikipedia)
Should indicate that we always use lower-case by convention
consider C++ versions in a header file that doesn't bring all of LMIC into scope. (ArduinoLoRaWAN?)

terrillmoore closed this as completed in

304de5e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment