Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analagous problem to LMIC confirmed tx-status problem #92

Closed
terrillmoore opened this issue Apr 2, 2019 · 0 comments
Closed

Analagous problem to LMIC confirmed tx-status problem #92

terrillmoore opened this issue Apr 2, 2019 · 0 comments
Assignees
Labels

Comments

@terrillmoore
Copy link
Member

As part of mcci-catena/arduino-lmic@53c27e4, we added the following:

            // compute exit status
            if (ev == EV_TXCANCELED) {
                // canceled: unsuccessful.
                fSuccess = 0;
            } else if (/* ev == EV_TXCOMPLETE  && */ LMIC.pendTxConf) {
                fSuccess = (LMIC.txrxFlags & TXRX_ACK) != 0;
            } else {
                // unconfirmed uplinks are successful if they were sent.
                fSuccess = 1;
            }

Arduino_LoRaWAN doesn't have those checks (for confirmed/unconfirmed uplink, and cancel) and it should.

@terrillmoore terrillmoore self-assigned this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant