Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruby 3 support #118

Merged
merged 4 commits into from
Feb 7, 2021
Merged

Add ruby 3 support #118

merged 4 commits into from
Feb 7, 2021

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jan 4, 2021 •
edited
Loading

fixes #117

mcmire
mcmire reviewed Jan 4, 2021
View reviewed changes
Copy link
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! There seems to be something wrong about the new addition to the workflow, so if we can get that working then I am cool with this.

.github/workflows/super_diff.yml Outdated Show resolved Hide resolved
super_diff.gemspec Outdated Show resolved Hide resolved
@mcmire mcmire merged commit c81d686 into splitwise:master Feb 7, 2021
@mcmire
Copy link
Collaborator

mcmire commented Feb 7, 2021

Thanks so much for adding this! Everything still seems to be working so that's a relief 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruby 3.0 support?
2 participants
@jcoyne @mcmire