Display Time-likes with more precision #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
add-more-precision-to-time-like
branch
4 times, most recently
from
7d16f96
to
0c2df96
Compare
Specifically, include subseconds in the inspected version of the
time-like to match the absolute maximum precision you can use when
defining a Time. This means that the following two Times will no longer
appear as though they are the same time when diffed:
Time.at(1620017167711.0 / 1000)
Time.local(2021, 5, 2, 22, 46, 7, 710_999)
mcmire
force-pushed
the
add-more-precision-to-time-like
branch
from
0c2df96
to
4f860a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, include subseconds in the inspected version of the
time-like to match the absolute maximum precision you can use when
defining a Time. This means that the following two Times will no longer
appear as though they are the same time when diffed: