Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in streaks embedded in sequences #50

Open
arnsholt opened this issue Nov 15, 2020 · 0 comments
Open

Bug in streaks embedded in sequences #50

arnsholt opened this issue Nov 15, 2020 · 0 comments

Comments

@arnsholt
Copy link

Unless I've misunderstood how streaks and sequences are supposed to work together, a streak that matches partially before failing backtracks too far in the list of conditions.

Consider the following database and query (txt extensions to placate GitHub's extension allowlist):

test.pgn.txt
query.json.txt

Scoutfish will only match the first game, not the second, which I think is wrong. The cause is scout.cpp:168-169, which sets condIdx to zero instead of 1, which means that in addition to discarding the failed partial streak match it also discards the matched e4 move which should not be discarded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant