Expand tilde in config_path #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcuadros
requested changes
Aug 11, 2017
helm/provider.go
Outdated
| rules := clientcmd.NewDefaultClientConfigLoadingRules() | ||
| rules.ExplicitPath = d.Get("kubernetes.0.config_path").(string) | ||
| explicitPath, err := expandTilde(d.Get("kubernetes.0.config_path").(string)) |
There was a problem hiding this comment.
please use homedir.Expand from github.com/mitchellh/go-homedir
jrhouston
pushed a commit
that referenced
this pull request
Feb 5, 2020
Bump helm dep module version to v3.0.3
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10.