Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid HTML #27

Open
mattherick opened this issue Jun 25, 2015 · 3 comments
Open

Invalid HTML #27

mattherick opened this issue Jun 25, 2015 · 3 comments

Comments

@mattherick
Copy link

Hi!

This

def self.url_params(gravatar_params)
  return nil if gravatar_params.keys.size == 0
  array = gravatar_params.map { |k, v| "#{k}=#{value_cleaner(v)}" }
  "?#{array.join('&')}"
end

causes invalid html, if I run the http://validator.w3.org

Line 93, Column 122: & did not start a character reference. (& probably should have been escaped as &.)…e66872a973005f1dae67?default=identicon&secure=true&size=50" width="50" height=…
Line 93, Column 134: & did not start a character reference. (& probably should have been escaped as &.)…a973005f1dae67?default=identicon&secure=true&size=50" width="50" height="50" />

Changing the "&" to "&' would fix it..

Can you fix this, or should i provide a pull request?

I know it is just a little "error", but if all other validations pass it would be fine if also this last one pass :-)..

Matthias

@veye
Copy link

veye commented Jul 7, 2015

Same here.

@reiz
Copy link

reiz commented Jul 7, 2015

+1

@veye
Copy link

veye commented Jul 7, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants