Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Some keywords don't have enough contrast in some interactive examples #858

Closed
adriancuadrado opened this issue Jul 13, 2022 · 3 comments · Fixed by #888
Closed
Labels
a11y ensuring all aspects of MDN is accessible to all dark-mode

Comments

@adriancuadrado
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/Web/CSS/calc

What specific section or headline is this issue about?

https://developer.mozilla.org/en-US/docs/Web/CSS/calc#try_it

What information was incorrect, unhelpful, or incomplete?

In dark mode it's hard to see the calc and var keywords.

image

What did you expect to see?

I expect to see those keywords with more contrast.

Do you have any supporting links, references, or citations?

image

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 13, 2022
@adriancuadrado adriancuadrado changed the title Some keywords don't have enough contrast in some interactive examples Dark mode: Some keywords don't have enough contrast in some interactive examples Jul 13, 2022
@sideshowbarker sideshowbarker removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 13, 2022
@sideshowbarker sideshowbarker transferred this issue from mdn/content Jul 13, 2022
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 13, 2022
@caugner
Copy link
Contributor

caugner commented Aug 22, 2022

FWIW The color is set here:

.token.selector,
.token.attr-name,
.token.string,
.token.char,
.token.function,
.token.builtin,
.token.inserted {
color: #2545a7;
}

@caugner caugner transferred this issue from mdn/yari Aug 22, 2022
@caugner caugner added dark-mode a11y ensuring all aspects of MDN is accessible to all and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Aug 22, 2022
@adriancuadrado
Copy link
Author

@caugner
I use Windows 10. There is a feature that allows you to change the amount of blue your display uses.
It's in Settings --> System --> Display --> Night light settings. I use it because I have understood long exposures to blue light can damage your eyes. I didn't realize it was because of this setting that I was having such a hard time to read some keywords in the linked documentation. Many people use this setting and I'd like to suggest to use this setting and set it to a strength of 85 to check the contrast properly. I can't send a screenshot because the screenshot will have the correct blue tone since this setting affects the whole operating system.

@queengooborg
Copy link
Collaborator

Hey @adriancuadrado, a recently merged PR will be fixing this accessibility and color contrast issue and will be published to the website in the near future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y ensuring all aspects of MDN is accessible to all dark-mode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants