Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort browsers for api/* #3049

Merged
merged 1 commit into from
Nov 3, 2018
Merged

Sort browsers for api/* #3049

merged 1 commit into from
Nov 3, 2018

Conversation

queengooborg
Copy link
Collaborator

Depends on #1882. Sorts all browsers in the API files.

@Elchi3
Copy link
Member

Elchi3 commented Nov 2, 2018

+12,042 −12,043

Something is else is changed? :)

@Elchi3
Copy link
Member

Elchi3 commented Nov 2, 2018

Ah, https://github.com/mdn/browser-compat-data/pull/3049/files#diff-04466bc6c370adc5fc2bcea4942e9e12
A new line was removed in api/AudioNodeOptions.json. Can you undo that? (or tell the script to not fiddle with this?)

@Elchi3 Elchi3 added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 2, 2018
@queengooborg
Copy link
Collaborator Author

Actually, @Elchi3, it looks like there was originally two newlines at the end of the file -- the script just removed the second newline!

@Elchi3
Copy link
Member

Elchi3 commented Nov 3, 2018

Makes sense, thank you! :)

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @vinyldarkscratch ! 👍

@Elchi3 Elchi3 merged commit f4f8ce8 into mdn:master Nov 3, 2018
@queengooborg queengooborg deleted the sort/api branch November 4, 2018 02:02
sbc100 added a commit to sbc100/browser-compat-data that referenced this pull request Apr 16, 2024
This was originally added as unavailable back in 2018 (mdn#3049).  However,
testing using the android webview shell shows that it is working fine.

The test I used was:

```
new Worker(URL.createObjectURL(new Blob(["console.log('my name is ' + self.name)"], {type: 'application/javascript'})), {name: "foo"})
```

I ran this is DevTools and it printed `my name is foo`.
queengooborg pushed a commit that referenced this pull request May 7, 2024
This was originally added as unavailable back in 2018 (#3049).  However,
testing using the android webview shell shows that it is working fine.

The test I used was:

```
new Worker(URL.createObjectURL(new Blob(["console.log('my name is ' + self.name)"], {type: 'application/javascript'})), {name: "foo"})
```

I ran this is DevTools and it printed `my name is foo`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants