Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data for text-decoration-thickness is out of date #5110

Closed
jensimmons opened this issue Nov 8, 2019 · 4 comments
Closed

Data for text-decoration-thickness is out of date #5110

jensimmons opened this issue Nov 8, 2019 · 4 comments
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS

Comments

@jensimmons
Copy link
Contributor

text-decoration-thickness shipped in Firefox 70.

The data (as it displays on Can I Use) says that text-decoration-thickness is only partially supported, with two notes.
https://caniuse.com/#feat=mdn-css_properties_text-decoration-thickness

1 Uses the non-standard name: text-decoration-width
2 Can be enabled by setting layout.css.text-decoration-width.enabled to true

Both of these things are no longer true. The notes should simply be removed. And Firefox should get full-support green boxes, just like Safari has. Firefox 70 shipped with full support for the current spec.

All references to text-decoration-width can simply be removed completely — from here and from MDN Docs. That was an earlier name that was considered as part of the CSSWG process. There are zero implementations that use -width at this point, and no historical reason to keep the info around. It just confuses things.

This technology is not "experimental" either. That flag should be removed from MDN. (Which I attempted to do, but it's still showing up.)

@queengooborg queengooborg added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Nov 9, 2019
@Elchi3
Copy link
Member

Elchi3 commented Nov 11, 2019

Thanks for your report, @jensimmons!

This was updated by @chrisdavidmills end of September for the Firefox 70 release in #4825
The MDN docs actually show it green and shipping in 70 https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-thickness#Browser_compatibility, so I think caniuse hasn't updated yet.

@Fyrd How often do you update caniuse's import of the MDN compat data? Seems like this isn't there yet.

This technology is not "experimental" either. That flag should be removed from MDN. (Which I attempted to do, but it's still showing up.)

I hope to remove the concept of "experimental" altogether, see #1528 (there seems to be consensus about getting rid of it finally).

@Fyrd
Copy link
Contributor

Fyrd commented Nov 11, 2019

Looks like the data's up to date but the converter's not processing the data correctly. Will work on a fix for this soon!

@Fyrd
Copy link
Contributor

Fyrd commented Nov 11, 2019

Got a fix in, should appear as expected now.

@Elchi3
Copy link
Member

Elchi3 commented Nov 12, 2019

Thanks for the very quick fix @Fyrd! 👍

I'm going to close this, but conversations about "experimental" will continue in #1528.

@Elchi3 Elchi3 closed this as completed Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

No branches or pull requests

4 participants