Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PerformanceObserver.supportedEntryTypes in Firefox #9333

Merged
merged 3 commits into from
Mar 4, 2021
Merged

PerformanceObserver.supportedEntryTypes in Firefox #9333

merged 3 commits into from
Mar 4, 2021

Conversation

jakub-g
Copy link
Contributor

@jakub-g jakub-g commented Mar 4, 2021

Bugzilla says v66: https://bugzilla.mozilla.org/show_bug.cgi?id=1512225
but I tested on BrowserStack that it's available only in v68

@jakub-g
PerformanceObserver.supportedEntryTypes in Firefox
5637a42 
Bugzilla says v66: https://bugzilla.mozilla.org/show_bug.cgi?id=1512225
but I tested on BrowserStack that it's available only in v68
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Mar 4, 2021
ddbeck
ddbeck requested changes Mar 4, 2021
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @jakub-g!

One suggestion in a line comment and I have a request that falls outside the diff: could you flip experimental to false? There's 3 implementations, so I don't think it's going anywhere.

api/PerformanceObserver.json Outdated Show resolved Hide resolved
@jakub-g
Copy link
Contributor Author

jakub-g commented Mar 4, 2021

@ddbeck thx for review, applied suggested changes

ddbeck
ddbeck approved these changes Mar 4, 2021
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit 3f16e4a into mdn:master Mar 4, 2021
@dependabot dependabot bot mentioned this pull request Mar 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakub-g @ddbeck