Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF117 HTMLElement.togglePopover() returns boolean behind pref #20439

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

hamishwillee
Copy link
Contributor

FF117 HTMLElement.togglePopover() returns boolean (behind pref) instead of None in https://bugzilla.mozilla.org/show_bug.cgi?id=1842845. This is due to a spec change.

Other browsers do not implement this yet, but it is worth adding the subfeature now - it will be needed when the pref is removed.

Related docs work can be tracked in mdn/content#27417

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 31, 2023
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a description for the sub feature? Otherwise returns_boolean will be rendered in the MDN compat table.

@hamishwillee hamishwillee requested a review from Elchi3 August 4, 2023 01:52
@hamishwillee
Copy link
Contributor Author

@Elchi3 Yes, thanks, done!

@Elchi3 Elchi3 merged commit 7dcafb4 into mdn:main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants