-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove never-supported nodeFromPoint #6929
Conversation
}, | ||
"firefox": { | ||
"version_added": false, | ||
"notes": "Implemented in Firefox but currently only works in chrome code." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/mozilla/gecko-dev/blob/f98dad153b59a985efd4505912588d4651033395/dom/webidl/DocumentOrShadowRoot.webidl#L18-L23 confirms this. There's a reference to w3c/csswg-drafts#556 which is still open, there isn't anything to implement yet.
https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot/nodeFromPoint and https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot/nodesFromPoint would have to be archived. @sideshowbarker do you have the power to do this? (Not merging this yet.) |
No, I don’t — and not sure who else among BCD contributors might, except for @chrisdavidmills |
Yup, I can do this. Do you think archiving is the best idea? I could just delete them, or perhaps redirect them to the main interface page, to avoid the chance of broken links. |
I don't know what's usually done with these pages, but I think @Elchi3 or @ddbeck helped me archive one in a previous instance. We will need to archive or remove a lot of pages to land the many PRs @saschanaz has sent so it'd be great to pick an approach and coordinate a bit. Maybe like this:
|
I agree with this and I like this as proposed. To fill in one detail: I like the idea of redirecting to the parent interface (if it exists). If there's no parent, then we'll need to take it on a case-by-case basis, perhaps with a bias toward deletion unless someone can come up with an affirmative case for preserving the page. For pages that need redirects, I'm happy to be the default second reviewer for the MDN redirect + merge. For deletes/archives, I think that needs extra permissions. I guess we pull in @chrisdavidmills for those? Any suggestions or objections before we just go for it? |
Sounds great to me, if @chrisdavidmills is up for some page deletion duty :) |
Yup, definitely! I'd like to go with @ddbeck 's suggestion of redirecting to parent page if there is a sensible parent to redirect to, or deleting if not. Aside from that, send me the list of pages and I can get to work. |
I've summarized our process in #6854 (comment) and will start with this very PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are Gecko APIs never exposed to web content. These pages need redirecting to the parent page:
https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot/nodeFromPoint
https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot/nodesFromPoint
Over to @ddbeck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redirects done and merging. Thanks everyone for coming together for a good way to handle these. 👍
A checklist to help your pull request get merged faster: