Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove never-supported nodeFromPoint #6929

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

saschanaz
Copy link
Contributor

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any: Remove items that has never been supported #6854, Remove totally unimplemented things #6768

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 15, 2020
},
"firefox": {
"version_added": false,
"notes": "Implemented in Firefox but currently only works in chrome code."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foolip
Copy link
Contributor

foolip commented Oct 22, 2020

@sideshowbarker
Copy link
Contributor

https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot/nodeFromPoint and https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot/nodesFromPoint would have to be archived. @sideshowbarker do you have the power to do this?

No, I don’t — and not sure who else among BCD contributors might, except for @chrisdavidmills

@chrisdavidmills
Copy link
Contributor

Yup, I can do this. Do you think archiving is the best idea? I could just delete them, or perhaps redirect them to the main interface page, to avoid the chance of broken links.

@foolip
Copy link
Contributor

foolip commented Oct 22, 2020

I don't know what's usually done with these pages, but I think @Elchi3 or @ddbeck helped me archive one in a previous instance.

We will need to archive or remove a lot of pages to land the many PRs @saschanaz has sent so it'd be great to pick an approach and coordinate a bit. Maybe like this:

  • Someone reviews to confirm historical non-implementation of the removed entries
  • That someone approves and ping a second reviewer who can archive/delete MDN pages
  • That second reviewer does the MDN thing and then merges the PR

@ddbeck
Copy link
Collaborator

ddbeck commented Oct 28, 2020

it'd be great to pick an approach and coordinate a bit. Maybe like this:

  • Someone reviews to confirm historical non-implementation of the removed entries
  • That someone approves and ping a second reviewer who can archive/delete MDN pages
  • That second reviewer does the MDN thing and then merges the PR

I agree with this and I like this as proposed. To fill in one detail: I like the idea of redirecting to the parent interface (if it exists). If there's no parent, then we'll need to take it on a case-by-case basis, perhaps with a bias toward deletion unless someone can come up with an affirmative case for preserving the page.

For pages that need redirects, I'm happy to be the default second reviewer for the MDN redirect + merge. For deletes/archives, I think that needs extra permissions. I guess we pull in @chrisdavidmills for those?

Any suggestions or objections before we just go for it?

@foolip
Copy link
Contributor

foolip commented Oct 28, 2020

Sounds great to me, if @chrisdavidmills is up for some page deletion duty :)

@chrisdavidmills
Copy link
Contributor

Sounds great to me, if @chrisdavidmills is up for some page deletion duty :)

Yup, definitely!

I'd like to go with @ddbeck 's suggestion of redirecting to parent page if there is a sensible parent to redirect to, or deleting if not.

Aside from that, send me the list of pages and I can get to work.

@foolip
Copy link
Contributor

foolip commented Oct 29, 2020

I've summarized our process in #6854 (comment) and will start with this very PR.

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redirects done and merging. Thanks everyone for coming together for a good way to handle these. 👍

@ddbeck ddbeck merged commit 39ae20a into mdn:master Oct 29, 2020
@saschanaz saschanaz deleted the nosupport-nodefrompoint branch October 30, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants