Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete UIEvent.cancelBubble() ? #4859

Closed
hamishwillee opened this issue May 10, 2021 · 3 comments · Fixed by #4900
Closed

Delete UIEvent.cancelBubble() ? #4859

hamishwillee opened this issue May 10, 2021 · 3 comments · Fixed by #4900
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@hamishwillee
Copy link
Collaborator

hamishwillee commented May 10, 2021

I think we should delete UIEvent.cancelBubble page (and mention of it in UIEvent).

There is no BCD for this, and it is marked as experimental and deprecated in MDN with the comment:

This property is not part of any specification. Although the similar Event.cancelBubble property was included in an old Working Draft of W3C DOM Level 2. Microsoft has a description of it on MSDN.

The link on MSDN just links back to Event.cancelBubble. What this means is that we have a method that is non-spec and deprecated and since we don't have BCD there is no way for anyone to tell what browsers it might work on (though I guess maybe the old version of Edge based on the MSDN link). Further because it isn't in a spec or implemented anywhere that we know of there is no trigger to clean this up.

So my thinking is we should delete this method as "never going to be helpful for anyone". We could perhaps redirect to Event.cancelBubble too (a nearly as not-useful property, but at least one that has some spec justification).

@chrisdavidmills ?

@hamishwillee hamishwillee added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label May 10, 2021
@chrisdavidmills
Copy link
Contributor

@hamishwillee yeah, I think I'd agree with this. It quite probably comes under the BCD irrelevant features guideline, and I know @foolip has bene making a bunchof removals based on that, getting rid of BCD and then removing the corresponding docs too.

@foolip
Copy link
Contributor

foolip commented May 10, 2021

This is more a case of a feature in the wrong place in the prototype chain than an irrelevant feature. It's on Event and https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelBubble exists, so the UIEvent pages should just be redirected to that, and maybe some parts can be salvaged?

@hamishwillee
Copy link
Collaborator Author

Thanks @foolip . There is no doubt you know more about Javascript than me - this reads like the property is defined in Event AND reimplemented in UIEvent (the Event version being widely supported, and the UIEvent version being deprecated).

Anyway, fixed in #4900 - the UIEvent version is removed and redirected. There was nothing extra to capture from the removed doc.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants