HTMLElement.togglePopover() live example #27942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
requested review from
sideshowbarker
and removed request for
a team
|
Preview URLs External URLs (2)URL:
(comment last updated: 2023-07-19 10:30:14) |
hamishwillee
force-pushed
the
ff115_toggle_popover
branch
from
d236124 to
1ebe729
Compare
hamishwillee
changed the title
sideshowbarker
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a spec change to make
HTMLElement.togglePopover()return a boolean rather than undefined. I started this update on the false understanding that this had been implemented in FF. Not the case there, or anywhere else (yet).Rather than throw away the work, I have used HTML comments to hide that.
The value this adds is that now the popup is a working live example, which additionally makes it clear that you have to think about what will happen if popovers are not supported (the popover HTML just renders!)