fix(css): Remove ::first-line from margin* props #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
wbamberg
approved these changes
Jan 20, 2024
|
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
teoli2003
pushed a commit
that referenced
this pull request
Jan 21, 2024
🤖 I have created a release *beep* *boop* --- ## [2.3.5](v2.3.4...v2.3.5) (2024-01-20) ### Bug Fixes * **css:** Remove ::first-line from margin* props ([#706](#706)) ([8858ac6](8858ac6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct the
alsoAppliesTofor the CSSmarginandmargin-{top,bottom,left,right.trim}properties.Motivation
The data claims that
margin*properties apply to the::first-linepseudoelement, which is untrue. They apply to::first-letter, but not::first-line. As reported by @Akindin in mdn/content#31806.Additional details
Related issues and pull requests
Fixes mdn/content#31806