Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update text-wrap to be a shorthand property #774

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Oct 14, 2024

Description

Specification: https://drafts.csswg.org/css-text-4/#propdef-text-wrap.
Make text-wrap a shorthand property of text-wrap-mode and text-wrap-style.

Motivation

Practically this will mean text-wrap: auto becomes valid according to the properties.json syntax.

Additional details

N/A

Related issues and pull requests

N/A

Specification: https://drafts.csswg.org/css-text-4/#propdef-text-wrap.
Make `text-wrap` a shorthand property of `text-wrap-mode` and
`text-wrap-style`. Pratically this will mean `text-wrap: auto` is valid.
@Gusted Gusted requested a review from a team as a code owner October 14, 2024 13:13
@Gusted Gusted requested review from pepelsbey and removed request for a team October 14, 2024 13:13
Copy link
Contributor

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@pepelsbey pepelsbey merged commit 2213097 into mdn:main Oct 18, 2024
4 checks passed
Copy link
Contributor

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants