Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ai-help): reset user quota on openai api error #430

Merged
merged 5 commits into from
Mar 1, 2024
Merged

fix(ai-help): reset user quota on openai api error #430

merged 5 commits into from
Mar 1, 2024

Conversation

argl
Copy link
Contributor

@argl argl commented Feb 29, 2024 •
edited
Loading

If there is an error talking to the OpenAI API, we reinstate the user's quota.
(MP-708)

@argl argl changed the title hooked in reinstating the user quota if there is an error on our side fix(ai-help): make sure the user quota is reset if there is an error talking to the openai api Feb 29, 2024
@argl argl marked this pull request as ready for review February 29, 2024 10:15
@argl argl requested a review from a team as a code owner February 29, 2024 10:15
caugner
caugner requested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ovrerall LGTM, just one comment regarding different behavior for subscribers.

src/db/ai_help.rs Outdated Show resolved Hide resolved
@argl argl requested a review from caugner March 1, 2024 09:52
caugner
caugner approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@caugner caugner changed the title fix(ai-help): make sure the user quota is reset if there is an error talking to the openai api fix(ai-help): reset user quota on openai api error Mar 1, 2024
@argl argl merged commit cd6fdf8 into main Mar 1, 2024
3 checks passed
@argl argl deleted the MP-708-ai-quota-fix branch March 1, 2024 11:34
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@argl @caugner