feat(ai-help): delete ai history after six months #437
Conversation
src/db/v2/mod.rs
Outdated
There was a problem hiding this comment.
I wonder what v2 under db refer to?
There was a problem hiding this comment.
I do not know, I put it there for consistency w.r.t. the bcd updates.
There was a problem hiding this comment.
After talking to @fiji-flo, I will move things around a bit.
caugner
requested review from
fiji-flo and
a team
and removed request for
a team
|
This pull request has merge conflicts that must be resolved before it can be merged. |
| let mut retry = 0; | ||
| const MAX_RETRIES: u32 = 40; |
There was a problem hiding this comment.
Curious why you use u32, since u8 would be sufficient for both, and the difference is probably negligible here?
There was a problem hiding this comment.
Yes, u8 would suffice here. It is test code though, so I we can be a bit more relaxed about this.
| loop { | ||
| records = ai_help_history::table | ||
| .filter(ai_help_history::user_id.eq(1)) | ||
| .select(ai_help_history::updated_at) | ||
| .get_results(&mut conn)?; | ||
| if records.len() == 1 { | ||
| break; | ||
| } | ||
|
|
||
| actix_rt::time::sleep(Duration::from_millis(5)).await; | ||
| retry += 1; | ||
| if retry > MAX_RETRIES { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe this could be made more readable by using the retry crate, and we could reuse it to stabilize those flaky tests?
There was a problem hiding this comment.
Yes, probably. Lets look into retry crate next time we have flakyness issues.
| if let Err(e) = do_delete_old_ai_history(pool).await { | ||
| error!("{}", e); | ||
| } |
There was a problem hiding this comment.
Just wondering out loud if this would be "more" idiomatic:
| if let Err(e) = do_delete_old_ai_history(pool).await { | |
| error!("{}", e); | |
| } | |
| do_delete_old_ai_history(pool) | |
| .await | |
| .map_err(|e| error!("{}", e)) | |
| .ok(); |
There was a problem hiding this comment.
Yes, it looks more rustful.
Adds a new admin endpoint that deletes all ai help history entries form the database that are more that 6 months old.
(MP-712)