fix(ai-help): avoid spawning thread for history if history is disabled #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
commented
Mar 4, 2024
Comment on lines
+272
to
+274
| if !history_enabled { | ||
| return Ok(None); | ||
| } |
There was a problem hiding this comment.
@fiji-flo I have second thoughts about early returning if !history_enabled, because that this function not only records the history, but also logs errors (including the stream ended without a finish_reason one).
There was a problem hiding this comment.
That should happen somewhere else. As in the new code path in the meta data PR.
There was a problem hiding this comment.
I agree. Let's wait for #424 to be merged and move the logic over in this PR afterwards.
…hread-if-history-disabled
caugner
commented
Mar 27, 2024
caugner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #424.
Related to MP-813.