Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

https://wiki.developer.mozilla.org/en-US/docs/MDN/Contribute/Feedback #3827

Closed
1 of 3 tasks
RCopeland opened this issue Oct 23, 2020 · 1 comment
Closed
1 of 3 tasks

Comments

@RCopeland
Copy link

Request type

  • Please close this issue, I accidentally submitted it without adding any details
  • New documentation
  • Correction or update

Details

I'm going though the svg filters tutorial and I *think theres an error in the example at the bottom.
The closing tag should be moved to wrap the primitive.

https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/SVG_Filters_Tutorial

    <filter id="drop-shadow">
      <feGaussianBlur in="SourceAlpha" stdDeviation="3" result="blur" />
      <feoffset in="blur" dx="4" dy="4" result="offsetBlur" />
      <feMerge>
        <feMergeNode in="offsetBlur" />
        <feMergeNode in="SourceGraphic" />
      </feMerge>
    </filter>

Doing that makes it work on my codepen project:

https://codepen.io/robcopeland/pen/eYzNmwe

@chrisdavidmills
Copy link
Contributor

Hi @RCopeland !

Thanks for pointing this out. I've fixed the version in the Wiki page: https://wiki.developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/SVG_Filters_Tutorial. Let me know if you think this needs any more.

I love your example BTW, I wondered if I could be cheeky and ask if you'd be interested in helping to expand the tutoral page? Seems rather incomplete at the moment ;-)

Finally, thanks for making the change on the content repo — that's not the live content right now, but it will be when we move to our new platform on December 14th. If you are interested in helping to test it further, let me know.

Best,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants