Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai-help): show canned answer without sources for off-topic questions #10575

Merged
merged 9 commits into from
Mar 1, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Feb 22, 2024

Summary

(MP-710)

Problem

We show consulted MDN content even for off-topic questions.

Solution

Show a canned answer without sources if we detect an off-topic question.


Screenshots

Before

image

After

image

Video:

Screen.Recording.2024-02-23.at.14.16.57.mov

How did you test this change?

Asked What is the best type of coffee to drink while coding? locally with mdn/rumba#427.

@caugner caugner requested a review from a team as a code owner February 22, 2024 21:42
@github-actions github-actions bot added plus work around features related to MDN Plus plus:ai-help labels Feb 22, 2024
@caugner caugner changed the title feat(ai-help): show error for off-topic questions feat(ai-help): show canned answer without sources for off-topic questions Feb 23, 2024
@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Feb 27, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Feb 28, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Feb 29, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Mar 1, 2024
Copy link
Contributor

@argl argl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caugner caugner merged commit fcd236a into main Mar 1, 2024
15 checks passed
@caugner caugner deleted the ai-help-off-topic-answer branch March 1, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plus:ai-help plus work around features related to MDN Plus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants