fix(cloud-function): use ts-node via NODE_OPTIONS #10873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
force-pushed
the
fix-cloud-function-use-node-options
branch
from
36512bb
to
4fc0b05
Compare
fiji-flo
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
We upgraded to latest Node v18, which no longer works well with direct invocation of
ts-node, but we missed to change the/cloud-functionscripts.Solution
Specify the
ts-node/esmloader viaNODE_OPTIONSinstead.How did you test this change?
Ran
npm run build-redirectandnpm run proxylocally with Node 18.20.1.