fix(build): ignore GITHUB_REF in mdn/yari #11398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
On stage, the "View this page on GitHub" links to the mdn/content repo always point to the
nextbranch, even though the build used themaincontent branch, because the build system uses theGITHUB_REFenvironment variable.Solution
Ignore the
GITHUB_REFenvironment variable in mdn/yari.How did you test this change?
Deployed to stage and tested that "View this page on GitHub" on https://developer.allizom.org/en-US/docs/Learn/HTML links to the right content branch (
main).