Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish language option breaks navigation #5172

Closed
Tracked by #5179
pablospanish9 opened this issue Jan 16, 2022 · 3 comments
Closed
Tracked by #5179

Spanish language option breaks navigation #5172

pablospanish9 opened this issue Jan 16, 2022 · 3 comments
Labels
🐛 bug Something isn't working, or isn't working as expected p1 We will address this soon and will provide capacity from our team for it in the next few releases. 🚉 platform keeping the platform healthy

Comments

@pablospanish9
Copy link

When I clicked on the Spanish option, your website translated it OK for that page. When I tried to navigate back to the English, the Spanish option was automatically tagged to your webpage and most navigation was broken. I could not freely navigate without this Spanish designation, which I did not want anymore, and most pages were not found.

https://developer.mozilla.org/es/docs/Web/Reference

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 16, 2022
@schalkneethling schalkneethling added 🐛 bug Something isn't working, or isn't working as expected p1 We will address this soon and will provide capacity from our team for it in the next few releases. 🚉 platform keeping the platform healthy and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jan 18, 2022
@schalkneethling schalkneethling added this to the Sprint 3: Platform milestone Jan 18, 2022
@schalkneethling
Copy link

Thank you for reporting, @pablospanish9. Quick question, if you for example go to https://developer.mozilla.org/en-US/docs/Web/JavaScript, then click on "Change language" and choose Español. The page will reload as es. Now, if you navigate around all is generally good i.e. it keeps the es locale?

If you now click on "Change language" again and choose "English US" the page reloads with en-US and navigating around keeps you in en-US?

When I tried to navigate back to the English

Did you use the "View in English" link?

@pablospanish9
Copy link
Author

Yes. It keeps the es language and it seems to be working OK with all other pages. It stays in es. And I can click the English and it stays in English. I emailed the link to the one page where I received the error. It is possible that the behavior is limited to that one page.

@schalkneethling
Copy link

It is possible that the behavior is limited to that one page.

Highly unlikely as they all use the same code logic. I think it may be that, that page really does not exist for es still. The es locale became a top-level locale in the last couple of days and so I suspect this will be resolved soon. If you want to bring this issue to their attention, please have a look at https://github.com/mdn/translated-content/

From you last description it sounds like things work as intended so, I am going to go ahead and close this issue for now. Thank you again for reporting and providing feedback.

Repository owner moved this from Backlog to Done in Yari Platform Engineering Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working, or isn't working as expected p1 We will address this soon and will provide capacity from our team for it in the next few releases. 🚉 platform keeping the platform healthy
Projects
Development

No branches or pull requests

2 participants