Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kumascript): mention path in render error message (v2) #8953

Merged
merged 3 commits into from
May 29, 2023
Merged

fix(kumascript): mention path in render error message (v2) #8953

merged 3 commits into from
May 29, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 29, 2023 •
edited
Loading

Summary

Same as #8936, but incorporating fixes for the build errors it caused.

How did you test this change?

Ran yarn tool spas and yarn build --locale en-us.

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label May 29, 2023
@caugner caugner requested a review from fiji-flo May 29, 2023 07:56
fiji-flo
fiji-flo approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@caugner caugner merged commit a9d7370 into main May 29, 2023
@caugner caugner deleted the mention-page-in-macro-render-failure-v2 branch May 29, 2023 08:51
@github-actions github-actions bot mentioned this pull request May 29, 2023
Merged
@caugner caugner mentioned this pull request May 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiji-flo fiji-flo fiji-flo approved these changes

Assignees
No one assigned
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caugner @fiji-flo