Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployer): escape markdown markup in link text #8996

Merged
merged 5 commits into from
Jul 20, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Jun 2, 2023

Summary

escape markdown markup in url text, as we may use _, * in slug, so only escape those two characters

Problem

See mdn/translated-content#13541, the link text __defineGetter__ has been formatted to defineGetter.

image

Solution

Escape those characters in link text.


How did you test this change?

None.

@github-actions github-actions bot added deployer Deployment (currently using AWS S3 and AWS Lambda) python Pull requests that update Python code labels Jun 2, 2023
Co-authored-by: Leo McArdle <leo@mca.is>
@yin1999 yin1999 requested a review from LeoMcA July 11, 2023 13:10
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LeoMcA LeoMcA merged commit 810edfa into mdn:main Jul 20, 2023
10 checks passed
@yin1999 yin1999 deleted the escape-markdown branch July 20, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployer Deployment (currently using AWS S3 and AWS Lambda) python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants