Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps-dev): add @babel/plugin-proposal-private-property-in-object #9338

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR adds @babel/plugin-proposal-private-property-in-object as a dev. dependency.

When running yarn dev, the following error message is shown:

One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in your
node_modules folder for unrelated reasons, but it may break at any time.

babel-preset-react-app is part of the create-react-app project, which
is not maintianed anymore. It is thus unlikely that this bug will
ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
your devDependencies to work around this error. This will make this message
go away.

After installing the dependency as suggested, no other such messages appear to be displayed.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jul 18, 2023
@queengooborg queengooborg changed the title Add @babel/plugin-proposal-private-property-in-object as dev. dep. fix(deps): Add @babel/plugin-proposal-private-property-in-object as dev. dep. Jul 18, 2023
@caugner caugner changed the title fix(deps): Add @babel/plugin-proposal-private-property-in-object as dev. dep. fix(deps-dev): add @babel/plugin-proposal-private-property-in-object Jul 18, 2023
@caugner caugner merged commit 0b4f31a into mdn:main Jul 18, 2023
10 checks passed
@queengooborg queengooborg deleted the add-devdep branch July 18, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants