feat(links): distinguish visited links (v2) #9931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only use --text-link color for unvisited links.
caugner
force-pushed
the
distinguish-visited-links-v2
branch
3 times, most recently
from
13db232
to
86c354c
Compare
caugner
force-pushed
the
distinguish-visited-links-v2
branch
from
86c354c
to
73ffa68
Compare
|
Need to publish to NPM after merge. Preview pages are still showing blue links: https://pr29943.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Popover_API/Using |
I merged #9920, so v2.33.1 should be published soon. |
fiji-flo
approved these changes
Nov 3, 2023
caugner
added
ux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9672 and avoids #9921.
Problem
Visited and unvisited links are not distinguished on MDN.
Solution
Distinguish visited links by reverting their color to the default color from the browser styles.
Screenshots
Note: This time, the screenshots were captured on port 5042 and contain a heading.
Before
After
How did you test this change?
Ran
yarn && yarn devand opened http://localhost:3000/en-US/docs/Web/HTML locally.