feat(menu): highlight active items #9940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
changed the title
caugner
changed the title
caugner
force-pushed
the
highlight-active-menu-items
branch
from
3572d0f
to
c530ef6
Compare
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The main menu doesn't visualize what section the user is currently in.
Solution
Highlight the current item(s).
Note: The challenge is that our menu is not strictly hierarchical, i.e. "Guides" -> "Accessibility" links to the "References" section. This will be fixed in a separate PR.
Screenshots
How did you test this change?
Opened https://developer.allizom.org/en-US/docs/Web/CSS and https://developer.allizom.org/en-US/plus/ai-help on stage.