Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(links): adopt visited link colors from Firefox #9961

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Nov 7, 2023

Summary

Fixes #9958.

Problem

Visited links are not readable in Safari with the dark theme.

Solution

Define visited link colors rathern than relying on browser defaults, adopting the visited link colors of Firefox.


Screenshots

What Before After
Safari / Dark image image
Chrome / Dark image image
Firefox / Dark image image
Safari / Light image image
Chrome / Light image image
Firefox / Light image image

How did you test this change?

@caugner caugner requested a review from a team as a code owner November 7, 2023 21:52
Copy link

@AnujaRajput727 AnujaRajput727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the design side!

@GHkrishna
Copy link

Wouldn't the name '--text-link-visited' be more appropriate than the '--text-visited'?
The latter might add to the confusion and mentioning the link specifically in the name will be a better approach.

Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@caugner
Copy link
Contributor Author

caugner commented Nov 8, 2023

Wouldn't the name '--text-link-visited' be more appropriate than the '--text-visited'? The latter might add to the confusion and mentioning the link specifically in the name will be a better approach.

Excellent question! The CSS Color Module draft defines LinkText and VisitedText, which probably relate to the CSS selectors :link and :visited, so that's why I named the variable --text-visited. 🙂

@caugner caugner merged commit 29839fb into main Nov 8, 2023
14 checks passed
@caugner caugner deleted the adopt-visited-link-colors-from-firefox branch November 8, 2023 10:54
@GHkrishna
Copy link

Wouldn't the name '--text-link-visited' be more appropriate than the '--text-visited'? The latter might add to the confusion and mentioning the link specifically in the name will be a better approach.

Excellent question! The CSS Color Module draft defines LinkText and VisitedText, which probably relate to the CSS selectors :link and :visited, so that's why I named the variable --text-visited. 🙂

Makes sense.

@caugner caugner added the typography Issues related to font color/decoration/size/weight label Nov 9, 2023
gurezo pushed a commit to gurezo/yari that referenced this pull request Nov 11, 2023
Ensures that visited links are readable in all browsers, including Safari.
gurezo pushed a commit to gurezo/yari that referenced this pull request Nov 11, 2023
Ensures that visited links are readable in all browsers, including Safari.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typography Issues related to font color/decoration/size/weight
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visited links are unreadable in dark mode
4 participants