Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the extension on wordpress admin panel #105

Closed
mdolr opened this issue Oct 10, 2020 · 5 comments
Closed

Disable the extension on wordpress admin panel #105

mdolr opened this issue Oct 10, 2020 · 5 comments
Assignees
Labels
bug Something isn't working hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed priority Should be trated in priority
Milestone

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 10, 2020

Apparently having the extension sending GET requests when hovering a button triggers action in wordpress and can lead to the deletion of some articles for example.

@mdolr mdolr added bug Something isn't working help wanted Extra attention is needed hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest priority Should be trated in priority labels Oct 10, 2020
@mdolr mdolr added this to the Next release milestone Oct 10, 2020
@rezziemaven
Copy link

rezziemaven commented Oct 11, 2020

Hey @mdolr! So just to clarify, you're saying that if a user who has the extension enabled in the browser and is in the admin panel of their own WordPress site, it can accidentally delete articles/ posts from their site?

@mdolr
Copy link
Owner Author

mdolr commented Oct 11, 2020

Exactly, if the user hovers an action the extension will send a GET request to the link behind the button and from what I understand wordpress uses GET requests for its API so the extension should be disabled on any wordpress admin panel

@rezziemaven
Copy link

rezziemaven commented Oct 11, 2020

Awesome, thanks for clarifying! I'd love to work on this; can you assign it to me?

@mdolr
Copy link
Owner Author

mdolr commented Oct 14, 2020

Hello @rezziemaven you've asked me to assign this issue aswell as #96 3 days ago, have you had time to work on those ? If not do you still plan to work on them ?

@rezziemaven
Copy link

Hey @mdolr, I haven’t had the time to work on either of them but yes, I still plan to work on both of them. I’ll have more time to work on it this weekend. I hope that’s okay with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed priority Should be trated in priority
Projects
None yet
Development

No branches or pull requests

2 participants