Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chinese translation #69

Closed
mdolr opened this issue Oct 6, 2020 · 5 comments
Closed

Add chinese translation #69

mdolr opened this issue Oct 6, 2020 · 5 comments
Labels
good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed translation

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 6, 2020

Hello,
The extension needs translation for different languages.

You can find the language code (or locale code) you should use on this page

Steps :

  • Create a _locales/[language_code] folder
  • Create a messages.json file at _locales/[language_code]/messages.json
  • Copy paste content from _locales/en/messages.json
  • Translate the "message" part for each JSON object
@mdolr mdolr added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest translation labels Oct 6, 2020
@plushugh
Copy link
Contributor

plushugh commented Oct 7, 2020 •
edited
Loading

I'll do it, Chinese is my first language😀

Assign it to me so I can work on it.

@plushugh
Copy link
Contributor

plushugh commented Oct 7, 2020 •
edited
Loading

It's done! My Repo

@plushugh
Copy link
Contributor

plushugh commented Oct 7, 2020

PR #75

@mdolr mdolr closed this as completed Oct 7, 2020
@Hsins
Copy link
Contributor

Hsins commented Oct 7, 2020

@mdolr There are Traditional Chinese and Simplified Chinese in the world. Would you mind to open another issue for "Add Traditional Chinese Translation" and assign it to me?

@mdolr
Copy link
Owner Author

mdolr commented Oct 7, 2020

@Hsins hey, just submit a pull request if you want to add a new language that is not in the issue list, let's not overcomplicate things 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdolr @Hsins @plushugh