Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t.privileged not updated in policy.substitute #9

Open
Cjen1 opened this issue Dec 17, 2019 · 0 comments
Open

t.privileged not updated in policy.substitute #9

Cjen1 opened this issue Dec 17, 2019 · 0 comments

Comments

@Cjen1
Copy link

Cjen1 commented Dec 17, 2019

    Log.info (fun m -> m "Policy.substititue %a for %a" pp_ip old_ip pp_ip new_ip) >>= fun () ->
    if PrivilegedSet.mem (SrcIP old_ip) t.privileged then begin
      PrivilegedSet.remove (SrcIP old_ip) t.privileged
      |> PrivilegedSet.add (SrcIP new_ip)
--    |> fun npriv -> t.privileged <- t.privileged end;

It appears that the last line should be fun npriv -> t.privileged <- npriv since npriv is the accumulation of all the changes above it.

(additionally subsequently matching is done on the old_ip to update it, should it not match on name?)

@Cjen1 Cjen1 assigned Cjen1 and unassigned Cjen1 Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant