Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - OIDC does not use end_session_endpoint to sign out users #4477

Open
5 of 6 tasks
austinvaness opened this issue Oct 31, 2024 · 3 comments
Open
5 of 6 tasks

[BUG] - OIDC does not use end_session_endpoint to sign out users #4477

austinvaness opened this issue Oct 31, 2024 · 3 comments
Labels
bug Something isn't working stale triage

Comments

@austinvaness
Copy link

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue (title field is above this).
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

When signed in via OpenID the user should be redirected to the end_session_endpoint url specified in the .well-known/openid-configuration to sign out. Instead I get redirected to Mealie's login screen.

I am using Authentik as my provider, which when configured correctly will redirect users to https://auth.mydomain.com/if/session-end/mealie/ so that they can switch users, sign out of Authentik entirely, or go to their Authentik dashboard. If the user is not redirected here, it becomes impossible to log out properly without going to the Authentik user dashboard directly.

Steps to Reproduce

  1. Sign in with OpenID using a provider that specifies end_session_endpoint
  2. Attempt to sign out

Please provide relevant logs

No relevant logs

Mealie Version

No response

Deployment

Docker (Linux)

Additional Deployment Details

No response

@austinvaness austinvaness added bug Something isn't working triage labels Oct 31, 2024
@casjdit
Copy link

casjdit commented Oct 31, 2024

Same problem with Keycloak

@cmintey
Copy link
Contributor

cmintey commented Oct 31, 2024

This isn't really a bug, more of a feature request. Mealie v1 had this feature because it was baked into the auth library we used. Mealie v2 changed to a different library (Authlib) which doesn't directly support this functionality

Copy link
Contributor

github-actions bot commented Dec 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale triage
Projects
None yet
Development

No branches or pull requests

3 participants