You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Hi
The menu service seems to be fundamentally floored to me in the following ways :
The default roles should be set to default to ALL roles defined in my User model. The reason for this is that adding a new role to the User model ALSO requires a change to the defaultRoles in the Menu service.
The default role(s) for a MenuItem should default to the roles defined on the parent Menu i.e. 'topbar'.
The default roles for a MenuSubItem should default to the roles defined on the parent MenuItem
Basically the 'topbar' menu should be automatically enabled for ALL roles. Adding a MenuItem to this, such as Articles, could then be defined to restrict this menu to JUST say an ['admin'] role if specified. Any SubMenuItem(s) would then default to be only the ['admin'] role as well. However, if I set my MenuItem to be ['admin', 'otherRole'] I could still restrict a particular SubMenuItem to be just available to the ['admin'] role but if not defined then it will be available to both ['admin', 'otherRole'].
The current way it works first required that I modify the 'topbar' menu item in the Menu service every time I add a new role to my User model otherwise that new role cannot add see MenuItem(s) even if I pass in ['newRole'] because by default ['newRole'] cannot see 'topbar'.
Also, the documentation for MenuItem is incomplete on the site as it does not mention the 'MenuType' parameter i.e. dropdown or item.
Steve
The text was updated successfully, but these errors were encountered:
Hi
The menu service seems to be fundamentally floored to me in the following ways :
Basically the 'topbar' menu should be automatically enabled for ALL roles. Adding a MenuItem to this, such as Articles, could then be defined to restrict this menu to JUST say an ['admin'] role if specified. Any SubMenuItem(s) would then default to be only the ['admin'] role as well. However, if I set my MenuItem to be ['admin', 'otherRole'] I could still restrict a particular SubMenuItem to be just available to the ['admin'] role but if not defined then it will be available to both ['admin', 'otherRole'].
The current way it works first required that I modify the 'topbar' menu item in the Menu service every time I add a new role to my User model otherwise that new role cannot add see MenuItem(s) even if I pass in ['newRole'] because by default ['newRole'] cannot see 'topbar'.
Also, the documentation for MenuItem is incomplete on the site as it does not mention the 'MenuType' parameter i.e. dropdown or item.
Steve
The text was updated successfully, but these errors were encountered: