This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
fix(articles): Article controllers name conflicts #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the naming conflicts for the Articles controllers. Due to how Angular injects the controllers into the StateProvider, naming conflicts were caused between the Articles public & admin module controllers. To resolve the issue the referenced controllers in the Articles admin route configurations must be unique, and match up with the Admin controllers.
|
I had included this fix in the Server-Side Pagination pull-request. However, it's more appropriate to have this fix in a separate merge. |
Fixed the client-side tests that were failing due to the naming conflicts.
|
Any bug open on this @mleanos or just the PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the naming conflicts for the Articles controllers.
Due to how Angular injects the controllers into the StateProvider,
naming conflicts were caused between the Articles public & admin module
controllers.
To resolve the issue the referenced controllers in the Articles admin
route configurations must be unique, and match up with the Admin
controllers.