fix(build): E2E coverage broken on Travis CI #1805
Conversation
|
@lirantal @simison Any thoughts here? Why are we using Firefox, rather than Chrome? Switching to Chrome and updating However, I have no idea what's going on with this (it only happens with the first job on each Node version) 😕 https://travis-ci.org/meanjs/mean/jobs/248564363#L516 Could this be an issue with Travis' "trusty" image? |
|
I didn't setup the E2E initially so I don't know the historical versions of using firefox, maybe it was only available at that time on Travis CI. |
|
Perhaps something changed with on 21st? https://blog.travis-ci.com/2017-06-21-trusty-updates-2017-Q2-launch |
|
I remember a few months ago someone tried a PR for Trustroots where they changed browser to Firefox (because no more PhantomJS). It threw some errors so I assume it had some similar issues. Would be awesome to support Firefox but seems like not worth the effort right now. |
|
@mleanos did you test this on Travis config? |
|
No. I haven't. :) I've exhausted almost every other config/option that I could think of, or find on the webs. I'll try this now. Thanks :) |
Seems to have gone away.. again with the 😕 smh |
|
@mleanos the problem wasn't neither one of these listed at trouble shooting, right? https://docs.travis-ci.com/user/gui-and-headless-browsers/#Troubleshooting I actually think we might've had that timeout issue at Trustroots. |
|
This is the error that is getting thrown each time I try to use Firefox.. I tried both and neither worked (I saw that someone downgraded to FF 46 & it solved addons:
firefox: latestaddons:
firefox: 46The troubleshooting link you sent seems to apply to Karma, and not Protractor, since our client-side tests run fine, but the E2E is failing. It's gotta be an issue with that Gecko driver, and I've tried setting a |
|
Please bear in mind that I'm learning the nuances of Travis CI as I go :) So there just might be something that I'm overlooking. As it stands, it doesn't look feasible to use Firefox at the moment. Unless we can figure out that Gecko driver path issue. It's odd that it popped up recently. The last thing I haven't tried is to remove the use of the "trusty" image. |
|
I think comment here says it all:
https://bugzilla.mozilla.org/show_bug.cgi?id=1338004 Totally not worth the pain yet — hopefully this will be easier eventually. |
|
Keep at it @mleanos! |
|
Out of curiosity, what's the benefit of using Firefox over Chrome in this instance? One thing that I've always felt, is that FF isn't tied to Angular, so it would probably be safe to say "if it works in FF, it will work in Chrome." - Is that the general sentiment? |
I may have run out of options though. So in order to get out builds to pass, we may just have to go with Chrome for now. |
Fixes an issue with the Travis CI builds failing at the E2E tests due to an apparent issue with the Mozilla Gecko web-driver used with Selenium. 1) Upgrades `gulp-protractor` to ensure Protractor v5> is used. 2) Removes `--firefox` option from the Travis CI Selenium `webdriver-manager update` step. 3) Changes Protractor config to use Chrome instead of Firefox.
mleanos
force-pushed
the
debug/travis-protractor-fails
branch
from
7cde6d9 to
66b7d46
Compare
mleanos
changed the title
|
I don't have a specific preference for FF really. I think maybe it was the only option available back then for Travis CI. Great work! |
|
LGTM! |
Update upstream fix(build): E2E coverage broken on Travis CI (meanjs#1805)
Fixes an issue with the Travis CI builds failing at the E2E tests due to an apparent issue with the Mozilla Gecko web-driver used with Selenium. 1) Upgrades `gulp-protractor` to ensure Protractor v5> is used. 2) Removes `--firefox` option from the Travis CI Selenium `webdriver-manager update` step. 3) Changes Protractor config to use Chrome instead of Firefox.
Fixes an issue with the Travis CI builds failing at the E2E tests due to
an apparent issue with the Mozilla Gecko web-driver used with Selenium.
gulp-protractorto ensure Protractor v5> is used.--firefoxoption from the Travis CI Seleniumwebdriver-manager updatestep.NOTE: This PR was originally created on a debugging branch to determine the issues with the E2E tests running on Travis CI builds. The below conversation will reflect the process of numerous experimental commits to track down the source of the issues. After a conclusion was made, the commits in this branch were squashed, and the commit details were changed here.