Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Bytes for bytes #24

Open
shikhar opened this issue May 23, 2021 · 2 comments
Open

Generate Bytes for bytes #24

shikhar opened this issue May 23, 2021 · 2 comments

Comments

@shikhar
Copy link
Contributor

shikhar commented May 23, 2021

https://docs.rs/prost-build/0.7.0/prost_build/struct.Config.html#method.bytes

This can facilitate fewer copies when working with data-heavy APIs.

@mechiru
Copy link
Owner

mechiru commented Aug 5, 2021

@shikhar Your suggestion is very cool. I'm a fan of the bytes crate.
However, this change is destructive and should be released with caution.
(Although it's not so popular as to release it so carefully 😅)

@shikhar
Copy link
Contributor Author

shikhar commented Aug 6, 2021

Indeed, it would be a breaking change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants