Slightly refactor launcher #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
* fix unordered list style - to * for bullets, same as other .md files * fix unordered list style * fix unordered list style * fix link to installation instructions installation instructions are no longer in the readme * + instructions for uploader * fix link * move info to readme.md * Add link to IA API The readme might be the first place somebody looks for info about Internet Archive’s API. * add links to APIs * Types of dump
* Robkam fix bullets (#1) * fix unordered list style - to * for bullets, same as other .md files * fix unordered list style * fix unordered list style * fix link to installation instructions installation instructions are no longer in the readme * + instructions for uploader * fix link * move info to readme.md * Add link to IA API The readme might be the first place somebody looks for info about Internet Archive’s API. * add links to APIs * Types of dump * rm gui.py, mv launcher and uploader to subfolders * Delete wikiteam3/launcher.py * Delete wikiteam3/uploader.py * Update __init__.py * Update DG __init__.py * Update L __init__.py * Update WT3 __init__.py * Update DG __init__.py * Create L __init__.py * Create L __main__.py * Create launch.py * Create U __init__.py * Create U __main__.py * Create upload.py * Update WT3 __init__.py
* rm gui.py, mv launcher and uploader to subfolders, tweak __init__ & __main__ * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add shebang to get past CI * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * revert * rm gui.py, mv launcher and uploader to subfolders * Delete wikiteam3/launcher.py * Delete wikiteam3/uploader.py * Update __init__.py * Update DG __init__.py * Update L __init__.py * Update WT3 __init__.py * Update DG __init__.py * Create L __init__.py * Create L __main__.py * Create launch.py * Create U __init__.py * Create U __main__.py * Create upload.py * Update WT3 __init__.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
robkam
commented
Nov 14, 2023
| # If both checks passed | ||
| if checktags and checkends: | ||
| os.chdir(Path(wikidir)) | ||
| time.sleep(1) |
There was a problem hiding this comment.
What's the purpose of the delay here?
robkam
commented
Nov 14, 2023
| compress_images(prefix) | ||
| # End of compression section | ||
|
|
||
| time.sleep(1) |
There was a problem hiding this comment.
What's the purpose of the delay here?
robkam
changed the title
|
I have some other enhancements in mind but PR now before adding further complexity. |
robkam
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use Path more often to work across different OS
new util checkxml.py module instead of external grep
changed file name prefix in domain.py - allow dots in names and replace non-alphanumeric with tilde instead of underscore
use py7zr instead of external 7z and out of launch.py to compress.py module