New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect cleanup of rules vector in Rule::operator= #6

Open

aldoshkind opened this issue Nov 3, 2023 · 0 comments

aldoshkind commented Nov 3, 2023

Hello!
I suppose there are incorrect cleanup of rules vector in Rule::operator=() here:

sdp-cpp/src/abnf/Rule.cpp

Line 50 in 4bf23de

rules.empty();

Shouldn't there be clear() insted of empty()?
In any case calling empty() without using it's return value makes no sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment