Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parent failure is not counted when child passes #23

Closed
medyagh opened this issue Feb 13, 2021 · 1 comment · Fixed by #24
Closed

parent failure is not counted when child passes #23

medyagh opened this issue Feb 13, 2021 · 1 comment · Fixed by #24

Comments

@medyagh
Copy link
Owner

medyagh commented Feb 13, 2021

example

--- FAIL: TestErrorSpam (51.27s)
    --- PASS: TestErrorSpam/KubeadmSteps (0.00s)

and

=== CONT  TestErrorSpam
    error_spam_test.go:62: (dbg) Done: out/minikube-linux-amd64 start -p nospam-20210212234950-6552 -n=1 --memory=2250 --wait=false --driver=docker  --container-runtime=docker: (45.032070558s)
    error_spam_test.go:77: unexpected stderr: "  - Using image gcr.io/k8s-minikube/storage-provisioner:v4"
    error_spam_test.go:91: minikube stdout:
        * [nospam-20210212234950-6552] minikube v1.17.1 on Debian 9.13 (kvm/amd64)
          - KUBECONFIG=/home/jenkins/minikube-integration/linux-amd64-docker-docker-10463-2698-4001c0a26744ccb855d14a889592f2353e4ec0bb/kubeconfig
          - MINIKUBE_BIN=out/minikube-linux-amd64
          - MINIKUBE_HOME=/home/jenkins/minikube-integration/linux-amd64-docker-docker-10463-2698-4001c0a26744ccb855d14a889592f2353e4ec0bb/.minikube
          - MINIKUBE_LOCATION=10463
        * Using the docker driver based on user configuration
        * Starting control plane node nospam-20210212234950-6552 in cluster nospam-20210212234950-6552
        * Creating docker container (CPUs=2, Memory=2250MB) ...
        * Preparing Kubernetes v1.20.2 on Docker 20.10.2 ...
          - Generating certificates and keys ...
          - Booting up control plane ...
          - Configuring RBAC rules ...
        * Verifying Kubernetes components...
        * Enabled addons: storage-provisioner, default-storageclass
        * Done! kubectl is now configured to use "nospam-20210212234950-6552" cluster and "default" namespace by default
    error_spam_test.go:92: minikube stderr:
          - Using image gcr.io/k8s-minikube/storage-provisioner:v4

https://storage.googleapis.com/minikube-builds/logs/10463/4001c0a/Docker_Linux.txt
https://storage.googleapis.com/minikube-builds/logs/10463/4001c0a/Docker_Linux.html

@prezha
Copy link
Contributor

prezha commented Feb 17, 2021

/assign :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants