allow_override flag does not work for assets

[majkrzak]

Updating the release fails when asset is beeing updated:

    - uses: meeDamian/github-release@1.0
      with:
        token: ${{github.token}}
        commitish: ${{github.sha}}
        tag: latest
        name: Latest draft
        prerelease: true
        gzip: false
        files: >
          file.pdf:paper/paper.pdf
        allow_override: true

ERR: Uploading file.pdf to Github release has failed
{
  "message": "Validation Failed",
  "request_id": "07C0:5BBF:F7389:15503D:5D7E3EF4",
  "documentation_url": "https://developer.github.com/v3",
  "errors": [
    {
      "resource": "ReleaseAsset",
      "code": "already_exists",
      "field": "name"
    }
  ]
}

After manually removing the asset it seems that tag and commitsh was also not updated.

[majkrzak]

I've recreated the action by myself
https://github.com/majkrzak/create-release

[meeDamian]

If I understand correctly, you have a latest release that you want to update with each new release - is that correct?

I don't think I've seen that pattern done on Github Releases before, is that a common thing?

[majkrzak]

Yes, that's my case. I'm building the preview of the LaTeX paper when pushed to the master and publish it as the "Latest draft" preview release. Hadn't saw this approach before and maybe it is not perfect one but it fits my case 😄 Anyway the issue is that allow_override: true generally does not let you probably override more than body

[meeDamian]

It should allow you to override everything except assets and tag, as it's the main identifier.

I actually thought about asset override, but figured that if upload of an asset with the same name is attempted more than once, it's an error, that should be shown to the user. Guess not always 😅.

As for the other things, I'll do more testing to see what's going on.

[majkrzak]

I'm not saying that my approach is correct. It sounds reasonable that assets are immutable. Maybe only in the "draft" release?

[meeDamian]

About tag and commitish - docs on them say that commitish is only used if git-tag doesn't exist. If it does exist, it's just used right away instead. And since git-tags and Github Releases, are not exactly the same thing, I'd say force pushing git tags (apart from being "The insane thing" according to git manual 😉), is also out of scope of this action :).

Plus seems like update action does work properly for other fields: https://github.com/meeDamian/github-release/commit/bb75309cfc0b7a207268b4a7a57eb66ef8e85e23/checks

https://github.com/meeDamian/github-release/releases/tag/v0.0.0-test-update

And I still have to think about overriding assets 🤔.

[meeDamian]

Please use https://github.com/actions/create-release and https://github.com/actions/upload-release-asset now instead.

[TomBrien]

Please use https://github.com/actions/create-release and https://github.com/actions/upload-release-asset now instead.

Does this comment still apply? I see that the deprecation notice was removed a few days ago, and I agree with the new note! Problem with using actions/create-release and actions/upload-release-asset is it doesn't allow for overwriting releases. I think...

[majkrzak]

You can always go with mine 🤷‍♂️ https://github.com/majkrzak/create-release

[meeDamian]

Hey @TomBrien, I removed the deprecation, because the official alternative was just way to cumbersome :/. That being said I just made assets override possible with v2.0.1, if you haven't switched to @majkrzak's one in the meantime, please do let me know how it works for you :).