Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Merge service.ts and serviceCore.ts #345

Open
mikesol opened this issue Nov 22, 2019 · 2 comments
Open

Merge service.ts and serviceCore.ts #345

mikesol opened this issue Nov 22, 2019 · 2 comments
Assignees
Labels
refactoring Housekeeping and pruning

Comments

@mikesol
Copy link

mikesol commented Nov 22, 2019

The separation of service.ts and serviceCore.ts used to make sense when service was used as a public wrapper around service core, but as the two evolved, they became pretty co-dependent and indistinguishable. I do not see any blockers to merging them, but there could be some distinctions between the two in the code base that need to be preserved.

It would be good to investigate how service and serviceCore are being called, note any meaningful distinctions, and either make these more apparent through better comments/interfaces or, if the distinctions do not warrant two separate files, merge the files.

@mikesol mikesol added the refactoring Housekeeping and pruning label Nov 22, 2019
@ksaaskil
Copy link
Contributor

I think the codebase is already quite tightly coupled in service-related stuff so I would maybe not try to merge the two classes. It's true that the separation between them is not very clear, but instead of adding tighter coupling now, I'd maybe rather start investigating what kind of new abstractions would be needed to support, for example, GraphQL-based services.

@carolstran
Copy link
Contributor

Any feelings on what Kimmo said @mikesol?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactoring Housekeeping and pruning
Projects
None yet
Development

No branches or pull requests

3 participants